hainenber commented on PR #43916: URL: https://github.com/apache/superset/pull/43916#issuecomment-5589499454
I'm cool with all steps but thinks these changes below are a bit overkill and complicates build logic. We have Dependabot PRs merged pretty often so the benefits would be somehow scuffled and `npm` does its job pretty fine to calculate dep graph's hash, we kinda don't have to roll out our own. ``` - Guards docker/docker-bootstrap.sh's per-container-start uv pip install -e ... reinstalls (superset-core, the app, and the postgres extra) behind a hash of pyproject.toml + requirements/*.txt (+ superset-core/pyproject.toml), stored in a marker inside the venv, so unchanged dependencies are skipped on restart instead of reinstalled every time. - Guards docker/docker-frontend.sh's unconditional npm install behind a hash of package.json/package-lock.json stored in a node_modules marker, skipping it when unchanged; adds a FORCE_NPM_INSTALL override to opt back into always installing. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
