rusackas commented on PR #43909: URL: https://github.com/apache/superset/pull/43909#issuecomment-5592814669
Same point CodeAnt raised above, already answered there: the carve-out is deliberate. A bare 4-digit epoch-ms value is under 10 seconds past 1970 and nobody's displaying that, while 4-digit years are exactly what #38949 broke. Also the proposed fix doesn't work as written. Gating isYear on Number(trimmed) > 3000 means only years above 3000 count as years, so "2017", "1987", "1970" all fall back into the epoch branch, which is the regression this PR fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
