rusackas commented on PR #43979: URL: https://github.com/apache/superset/pull/43979#issuecomment-5593027868
Thanks for the deep dive here, @aminghadersohi, and for catching the ordering bug yourself. Pushed a follow-up. Thread B was right, growing the descendant did nothing for `element.screenshot()` since none of the ancestors between it and `.chart-container` grew along with it. `.slice_container` and the ag-Grid table plugin's wrapper now reset to `height: auto` too. Also fixed the ordering issue you found, `_expand_scrollable_content` now runs a second time after `_wait_for_charts_ready` so a grid that mounts late isn't silently skipped, and threaded `report_execution_context`'s remaining deadline into the ag-Grid poll instead of the fixed 5s (Thread A). Swapped the two dead selectors from the nit for a generic "actually clipping" check while I was in there. Still no browser in this environment either, so this is unit tests (113 passing) plus re-reading the source you cited, not a live capture. Holler if you spot anything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
