mikebridge commented on PR #44028: URL: https://github.com/apache/superset/pull/44028#issuecomment-5593453761
@aminghadersohi — ready for review (undrafted). CI green across all dialects on `0bccd7fd7f` (test-postgres/mysql/sqlite/unit all pass). This reconciles dashboard `position_json` against `dashboard_slices` membership on save: a CHART layout node referencing a chart absent from every Slice row (hard-deleted / never existed) is swapped in place for a markdown placeholder, mirroring the frontend `swapUnreachableChartSlots` (#41551). Soft-deleted members are preserved by construction (resolution bypasses only the soft-delete filter, not existence), and both write paths are covered (`set_dash_metadata` + the raw `position_json` PUT). It's had a 5-lens local review + an independent cross-model pass; the latter caught and closed input-hardening edge cases (malformed-JSON layout nodes, chartId=0, non-object position_json) — see the SUMMARY and the tests (both paths, soft-delete-preserved, reverted-fix control, a parameterized non-object-PUT test, and a PUT wiring test). Appreciate a look when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
