rusackas commented on PR #38791: URL: https://github.com/apache/superset/pull/38791#issuecomment-5593778777
Thanks for taking this on, nice cut on the styled-components debt! Couple of things before this is mergeable, though. The new trigger `span` has `role="button"` and the `:focus-visible` outline, but no `tabIndex`, so it never actually gets keyboard focus, the real focusable element is still the inner `StyledFilterCount` button underneath it. So the a11y fix this PR is built around doesn't actually kick in on Tab, which is the opposite of the goal here. Copilot's threads on that and on `popoverContentRef` going unused now (the parent still calls `.focus()` on it when opening the popover) look like real regressions to me, not nits. There's also a bot thread flagging that the arrow-key test doesn't actually test arrow-key navigation, worth a look too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
