rusackas commented on PR #43936: URL: https://github.com/apache/superset/pull/43936#issuecomment-5593547913
Couple of things before this can merge: Bito's two findings here look right and neither's addressed yet, the all-NaT crash in `_resolve_week_grain_offset` and the sub-week offset collapsing to a no-op instead of falling back to the per-row shift. Might be worth a test for anything under a week too, since nothing here exercises that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
