rusackas commented on PR #43116: URL: https://github.com/apache/superset/pull/43116#issuecomment-5594482926
Heya @SaadAhmed7. sadpandajoe's question from last week is still sitting unanswered: timeComparePivotOperator runs off baseQueryObject before extra_metrics gets appended, so would `sort_metric__1 year ago` ever actually show up in a real response, or is the test the only place that key exists? Worth settling before this merges, since it'd mean the fix doesn't touch a real code path. CI's also gone stale (looks cancelled, not actually red), probably needs a rebase for a fresh run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
