rusackas opened a new pull request, #44037:
URL: https://github.com/apache/superset/pull/44037

   ### SUMMARY
   Resolves code-scanning alert #2679 
([zizmor/self-repository](https://github.com/apache/superset/security/code-scanning/2679))
 on `.github/workflows/superset-python-presto-hive.yml:152`.
   
   The `Setup Postgres` step in the `test-postgres-hive` job references 
`.github/actions/cached-dependencies` via the workspace-relative `uses: ./...` 
syntax, which zizmor's `self-repository` audit flags in favor of the newer 
`uses: $/...` syntax. The mechanical rewrite doesn't apply here: 
`cached-dependencies` is a git submodule (see `.gitmodules`), and `$/...` 
resolves action files directly from the repository tree without performing a 
real (submodule-aware) checkout, so it can't see past the submodule's gitlink 
into the actual `action.yml`.
   
   This mirrors the identical, already-suppressed false-positive pattern used 
for the sibling `cached-dependencies` step in the same job (`Start Celery 
worker`) and elsewhere in the repo (e.g. `superset-translations.yml`), using 
the same explanatory comment and `# zizmor: ignore[self-repository]` 
trailing-comment placement.
   
   Only this one occurrence (line 152, alert #2679) is touched. The file's 
other `self-repository` finding (the `test-postgres-presto` job's `Start Celery 
worker` step, alert #2665) is already tracked and addressed by a separate open 
PR (#43986).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A — CI workflow YAML only, no UI change.
   
   ### TESTING INSTRUCTIONS
   - `zizmor .github/workflows/superset-python-presto-hive.yml` no longer 
reports a live `self-repository` finding for line 152 (now ignored instead of 
flagged).
   - `pre-commit run --files .github/workflows/superset-python-presto-hive.yml` 
passes, including the `zizmor` hook.
   - Workflow runtime behavior is unchanged; only a trailing comment and 
explanatory comment block were added.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   Resolves code-scanning alert #2679
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to