rusackas commented on code in PR #43901:
URL: https://github.com/apache/superset/pull/43901#discussion_r3963698896


##########
docs/admin_docs/security/security.mdx:
##########
@@ -132,6 +132,31 @@ tables in the **Permissions** dropdown. To select the data 
sources you want to a
 You can then confirm with users assigned to the **Gamma** role that they see 
the
 objects (dashboards and slices) associated with the tables you just extended 
them.
 
+### Actionable Access-Denied Messages
+
+When a viewer opens a chart or dashboard built on a dataset they don't have 
access to, Superset
+shows a plain-language error naming the dataset (or tables, for SQL Lab) and, 
when known, the

Review Comment:
   Good catch, updated to say dataset owners — that's what the payload actually 
pulls from.



##########
docs/admin_docs/security/security.mdx:
##########
@@ -132,6 +132,31 @@ tables in the **Permissions** dropdown. To select the data 
sources you want to a
 You can then confirm with users assigned to the **Gamma** role that they see 
the
 objects (dashboards and slices) associated with the tables you just extended 
them.
 
+### Actionable Access-Denied Messages
+
+When a viewer opens a chart or dashboard built on a dataset they don't have 
access to, Superset
+shows a plain-language error naming the dataset (or tables, for SQL Lab) and, 
when known, the
+chart owners to contact. You can also point users at your own access-request 
process by setting
+`PERMISSION_INSTRUCTIONS_LINK` in `superset_config.py`:
+
+```python
+PERMISSION_INSTRUCTIONS_LINK = (
+    
"https://access.example.com/request?dataset={datasource_name}&user={username}";
+)
+```
+
+The URL may include any of the following placeholders, which are substituted 
with URL-encoded
+values so the link can deep-link into an internal ticketing or access-request 
tool with the

Review Comment:
   Documented — noted that only the placeholders matching the error type get 
filled and added table_names to the example so it covers SQL/table denials too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to