gkneighb commented on PR #43571:
URL: https://github.com/apache/superset/pull/43571#issuecomment-5601472387
Pushed `e08d75c5d5` — rebased onto current master (past the gauge merge) and
addressed the review:
**@aminghadersohi — query ordering (your finding #1):** `map_radar_config`
now emits `sort_by_metric`, so `_build_single_query_dict` orders by the first
metric descending — the exact `Radar/buildQuery.ts:38` behaviour, and it makes
the config/mapper docstrings ("orders by the first metric descending") true
rather than aspirational. Added a query-context regression test asserting the
built query carries a descending first-metric `orderby`. I also added `radar`
to that builder's `sort_by_metric` comment.
Your findings #2 (native round-trip/update), #3 (Vega preview
`viz_to_mark`), and #4 (recommendation coverage) I've left as-is per your own
assessment that they're pre-existing, family-wide MCP behaviours the merged
gauge plugin shares — happy to open a tracking issue for the family rather than
single out radar.
**@gabotorresruiz — docstring gap:** `radar` is now in `generate_chart.py` —
the `one of:` list, a per-type bullet, and a `"radar"/"spider"` quick-lookup
alias — matching the pattern from the gauge review.
(`get_chart_type_schema.py`'s core-type list already lists it too.)
CI re-running on the rebased head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
