aminghadersohi commented on PR #43679: URL: https://github.com/apache/superset/pull/43679#issuecomment-5606023616
Addressed the three follow-up suggestions in 36307ceb2b and reconciled the branch with master in 4b00500010. Dataset rebind validation now ignores explicitly supplied clears, removes only incompatible inherited query fields, and retains unrelated presentation/custom state. Filter deduplication compares comparator values for ordinary filters while preserving the intended single generated temporal binding. Focused regressions cover explicit-empty rebinds, granular incompatible-state pruning, and distinct comparators. Post-merge pre-commit checks (mypy, ruff, pylint, and formatting) pass on all five changed Python files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
