etr2460 commented on a change in pull request #8596: [css] Simplifying SQL
toolbar item margins, fixing overflow bug
URL:
https://github.com/apache/incubator-superset/pull/8596#discussion_r348680444
##########
File path: superset/assets/src/SqlLab/components/SqlEditor.jsx
##########
@@ -314,7 +313,7 @@ class SqlEditor extends React.PureComponent {
onDragStart={this.onResizeStart}
onDragEnd={this.onResizeEnd}
>
- <div ref={this.northPaneRef}>
+ <div ref={this.northPaneRef} className="NorthPane">
Review comment:
i know we haven't been overly consistent with css classes, but i most
commonly see `camelCase` or `kebab-case` in Superset, so let's use one of
those? (instead of adding another style `PascalCase`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
