sadpandajoe opened a new pull request, #44110: URL: https://github.com/apache/superset/pull/44110
### SUMMARY The scheduled full-repository pre-commit run fails because the semantic-view search test reads `call_args` from a method typed as a regular callable. Assert that the implementation is the `MagicMock` supplied by the fixture before inspecting its recorded arguments. Failure: https://github.com/apache/superset/actions/runs/34091125458 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; test typing only. ### TESTING INSTRUCTIONS - Reproduced the error before the fix with `pre-commit run mypy --files superset-core/src/superset_core/semantic_layers/view.py tests/unit_tests/semantic_layers/values_endpoint_test.py`; the same command passes after the fix. - `pre-commit run` passes for the staged change. - Full-tree mypy no longer reports this error; local full-tree validation reports a separate unused type-ignore in `superset/db_engine_specs/mysql.py:476`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
