sadpandajoe opened a new pull request, #44125: URL: https://github.com/apache/superset/pull/44125
### SUMMARY The shared CI/Showtime entrypoint starts the server even when initialization exits nonzero. Stop startup on that failure, preserve explicit `SERVER_THREADS_AMOUNT` values with an eight-thread default, and use `exec` to hand the entrypoint process to the server. Includes behavioral regression tests and Docker documentation. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. Before: failed initialization could still launch the server, thread overrides were discarded, and an outer shell remained. After: initialization failure stops startup, overrides are honored, and the server inherits the entrypoint PID. ### TESTING INSTRUCTIONS Run the isolated shell-process regression tests (no running Superset or database required): ```bash PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python3 -m pytest --noconftest -o addopts='' -p no:cacheprovider tests/unit_tests/docker_ci_entrypoint_test.py bash -n docker/entrypoints/docker-ci.sh ``` - All five cases pass: initialization failure propagation, startup order, default/custom/empty thread values, process handoff, and server exit status. Three cases fail against the original script. - Staged `pre-commit run` passes, including mypy and Ruff. - Independent review found no issues. - Full Docker/ECS deployment was not run. This fixes confirmed entrypoint defects; it does not establish the cause of the observed AWS health-check failure. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
