rusackas commented on PR #40907: URL: https://github.com/apache/superset/pull/40907#issuecomment-5612026149
Thanks for this, @ponichWebKnight. CI's failing though, `test_prepare_drill_detail_query_allows_datasource_without_flag` is asserting the wrong default sort column and mypy's flagging a couple of type errors in the test files, so this isn't mergeable yet. Also, three different bots independently flagged that `serverPagination` is read inside `handleSortByChange` in `TableChart.tsx` but missing from its `useCallback` deps, that one looks legit. I'll see about fixing this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
