rusackas commented on PR #43187: URL: https://github.com/apache/superset/pull/43187#issuecomment-5612062318
The fix itself makes sense to me — a tag that loses the SAVEPOINT race is still named by the import, so the cleanup sweep shouldn't treat it the same as a tag the user actually removed. Good catch, and the test reproduces the race directly instead of just asserting the happy path. This is showing as conflicting with master right now, though, so it can't land as-is. Once it's rebased I'll take another look. There's also still an open thread from codeant on the `begin_nested()` call flushing pending session state before the SAVEPOINT is established — worth confirming that's a non-issue (or fixing) before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
