codeant-ai-for-open-source[bot] commented on code in PR #44128:
URL: https://github.com/apache/superset/pull/44128#discussion_r3975118554
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -926,6 +926,23 @@ while True:
page += 1
```
+## Trash Listing (Soft-Deleted Objects)
+
+When the `SOFT_DELETE` feature flag is enabled, deleting a chart or dashboard
moves it to trash rather than removing it outright. The `list_charts` and
`list_dashboards` tools accept a `deleted_state` parameter to surface those
trashed objects:
+
+- `deleted_state="only"` โ return only trashed objects
+- `deleted_state="include"` โ return live and trashed objects together
+- Omitted (default) โ live objects only; trashed objects are excluded
+
+```python
+# List only trashed charts
+result = mcp.list_charts(deleted_state="only")
Review Comment:
**Suggestion:** `list_charts` requires all parameters inside `request`; this
example passes `deleted_state` at the top level and produces a validation
error. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=df90e6e398a043208c29aff53009e9cd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=df90e6e398a043208c29aff53009e9cd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/admin_docs/configuration/mcp-server.mdx
**Line:** 939:939
**Comment:**
*Api Mismatch: `list_charts` requires all parameters inside `request`;
this example passes `deleted_state` at the top level and produces a validation
error.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44128&comment_hash=593c102b62ce235f5af76209642a37ac10965e13290d98d62e47d0b930594964&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44128&comment_hash=593c102b62ce235f5af76209642a37ac10965e13290d98d62e47d0b930594964&reaction=dislike'>๐</a>
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -926,6 +926,23 @@ while True:
page += 1
```
+## Trash Listing (Soft-Deleted Objects)
+
+When the `SOFT_DELETE` feature flag is enabled, deleting a chart or dashboard
moves it to trash rather than removing it outright. The `list_charts` and
`list_dashboards` tools accept a `deleted_state` parameter to surface those
trashed objects:
+
+- `deleted_state="only"` โ return only trashed objects
+- `deleted_state="include"` โ return live and trashed objects together
+- Omitted (default) โ live objects only; trashed objects are excluded
+
+```python
+# List only trashed charts
+result = mcp.list_charts(deleted_state="only")
+```
+
+Trashed rows carry a non-null `deleted_at` timestamp in the response
(populated only when `deleted_state` is used). Visibility follows the same
restore-audience scoping as the equivalent REST API filters
(`chart_deleted_state` / `dashboard_deleted_state`): a caller sees only the
trashed objects they own, unless they hold an admin role, in which case all
trashed objects are visible.
Review Comment:
**Suggestion:** This says non-admin callers see only objects they own, but
the filters also expose trashed objects the caller can edit, so editors may be
misled about visibility. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b20d2214f0884c94a69aa271bec1b945&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b20d2214f0884c94a69aa271bec1b945&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/admin_docs/configuration/mcp-server.mdx
**Line:** 942:942
**Comment:**
*Api Mismatch: This says non-admin callers see only objects they own,
but the filters also expose trashed objects the caller can edit, so editors may
be misled about visibility.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44128&comment_hash=b954ea0e79c35191ab773029dc7e64d8b0fb875d2155604ca3509967b2168252&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44128&comment_hash=b954ea0e79c35191ab773029dc7e64d8b0fb875d2155604ca3509967b2168252&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
