aminghadersohi commented on PR #43567: URL: https://github.com/apache/superset/pull/43567#issuecomment-5612411799
Thanks for the refresh. Rechecked `beac31e84df6` against `de8ae20193`: shared compile/unsaved-query ordering, query-error propagation, ambiguous case matching, and primary Funnel guidance are fixed. Same-viz updates also preserve omitted filters/presentation now. Material gaps remain in the targeted reproductions: - **Update defaults still overwrite saved choices.** Immediate, preview-first, and the cached-update merge all turn omitted `sort_by_metric=false`, `row_limit=4`, and `color_scheme=lyftColors` into `true`, `10`, and `supersetColors`. Omission-aware handling in `merge_chart_form_data` is Gauge-only. Explicit overrides and empty-filter clears pass. - **Native/frontend contract remains incomplete.** `groupby: ["stage"]` with saved/SIMPLE/SQL native metrics fails schema validation; multiple dimensions and controls such as `show_labels`/`percent_calculation_type` are rejected. The Funnel schema/mapper are unchanged. - **Previews remain unfaithful.** For stage/value rows, unsaved Vega still has only a color encoding (no value axis), and ASCII falls back to a table. Saved `_funnel_spec` still picks fields positionally and forces descending order, ignoring `sort_by_metric=false` (`get_chart_preview.py:939–970`). Malformed nonnumeric metric values still produce normal previews. - **Metric validation remains incomplete.** Tier 1 accepts text-valued SIMPLE `MAX(stage)`, a VARCHAR saved metric, SQL `MAX(stage)`, and a metric alias colliding with `stage`. A mocked text-valued SQL result also passes `_compile_chart`. - **Coverage/recommendations:** the 18 Funnel tests are unchanged, without Funnel generate/update/cached-update/get-data/all-format product-path coverage; progression-shaped recommendations still omit Funnel. Verification: full MCP chart suite **1,563 passed, 1 skipped**, plus focused reproductions from an isolated export. CI has no failing checks (the previous license-check failure is gone); GitHub reports `MERGEABLE` / `CLEAN`. No contributor code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
