aminghadersohi commented on PR #43570:
URL: https://github.com/apache/superset/pull/43570#issuecomment-5612451306
@gkneighb Thanks—fresh finite pass at
`aea68245737c16e6868431474ccf0f61fc16dd9b` confirms the **scalar-groupby
blocker is fixed**: registered FastMCP generate (saved/unsaved) and update
(immediate/preview-first) all succeed with mocked persistence/query execution.
The `normalized` knob and discovery text are fixed too. The rebase also
improves error-envelope rejection, ambiguous-name rejection, and preservation
of filters/template/presentation state.
Two material product gaps still reproduce:
- **Omitted controls overwrite saved state, including the new knob.** Start
with `normalized:true, normalize_across:"y", row_limit:42`; call `update_chart`
with the same `chart_type:"heatmap_v2", x_axis:{name:"day"},
y_axis:{name:"hour"}, metric:{name:"trips",aggregate:"COUNT"}`, omitting those
controls. Both immediate and preview-first form data become
`false/"heatmap"/10000`. Please extend explicit-field-aware merging to Heatmap;
explicit values and `filters:[]` already work. Native string axes and
saved/SIMPLE/SQL metric forms still fail typed round-trip.
- **Preview/result fidelity remains open.** For rows
`{day:"Mon",hour:8,"COUNT(trips)":5}` and
`{day:"Tue",hour:9,"COUNT(trips)":7}`, saved/key/combined-key public Vega
previews still return circles, not metric-coloured cells; direct unsaved Vega
returns a bar with only X encoding. Missing metric values or a nonnumeric
last-row metric still produce successful preview/data responses. Shared Heatmap
cell/result validation—or an explicit unsupported-preview response—is needed.
Failed-query envelopes are correctly rejected now.
The other [previously reported
gaps](https://github.com/apache/superset/pull/43570#issuecomment-5590453024)
remain: sorting/rank processing, same-canonical-axis acceptance, and
Jinja/cache/rebind parity. I recognize server-side normalization/time grain are
explicitly deferred; this is not a renewed scalar-groupby finding.
Checks: **1,609 passed / 1 skipped** chart/query tests; **356 passed**
common/API tests; **60** temporary probe cases passed. Ruff, mypy, applicable
pre-commit hooks and diff checks passed. No contributor-branch changes,
review-state changes, or thread resolutions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
