codeant-ai-for-open-source[bot] commented on code in PR #44096:
URL: https://github.com/apache/superset/pull/44096#discussion_r3975295384
##########
superset-frontend/src/dataMask/reducer.ts:
##########
@@ -138,8 +138,20 @@ function fillNativeFilters(
// (2) loaded has a value but no extraFormData and the default does โ the
// "value present in UI but not applied to charts" gap-window case
where
// a permalink was captured before FilterValue produced extraFormData.
+ // A select filter's explicit match-nothing predicate is a complete clear,
+ // not an incomplete permalink captured while the filter was initializing.
+ const isExplicitSelectClear =
+ filter.filterType === 'filter_select' &&
+ !loadedHasValue &&
+ loaded?.extraFormData?.adhoc_filters?.some(
+ predicate =>
+ predicate.expressionType === 'SQL' &&
+ predicate.clause === 'WHERE' &&
+ predicate.sqlExpression === '1 = 0',
+ );
Review Comment:
**Suggestion:** A malformed permalink can store a non-array `adhoc_filters`
value or null entry; this call then throws during dashboard hydration instead
of restoring the default. [type error]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=69b8a5c6730f43ed8ef641762b75fbf9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=69b8a5c6730f43ed8ef641762b75fbf9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dataMask/reducer.ts
**Line:** 146:151
**Comment:**
*Type Error: A malformed permalink can store a non-array
`adhoc_filters` value or null entry; this call then throws during dashboard
hydration instead of restoring the default.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44096&comment_hash=31b3dab25bb90410158e4c46052f0e77d16bb2048ba182f218b1c5eb475ed4a7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44096&comment_hash=31b3dab25bb90410158e4c46052f0e77d16bb2048ba182f218b1c5eb475ed4a7&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
