bito-code-review[bot] commented on PR #43967: URL: https://github.com/apache/superset/pull/43967#issuecomment-5614704252
<!-- Bito Reply --> The current implementation of the dataset deletion impact check relies on `can_access_*` permissions, which can lead to an incorrect `count` of zero if the user is restricted from viewing certain dependent charts or dashboards. This results in the modal falsely assuring the user that no objects depend on the dataset, even though those objects exist and would be broken by the deletion. To address this, the endpoint should follow the pattern used in `serialize_dataset_purge_impact`, which provides a total `count`, a redacted `result` list, and a `restricted_count` field. This approach ensures that even if a non-admin editor is restricted from seeing specific dependents, the system still reports the total impact, preventing the false assurance of zero dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
