Ujjwaljain16 commented on issue #33272: URL: https://github.com/apache/superset/issues/33272#issuecomment-5618960270
i dug into this further and have a fix ready for review the root cause is that `clean_perms()` only removes orphaned PermissionView rows; it doesn't remove well-formed permissions whose underlying endpoint/method was deprecated in a previous release i found 25 deprecated permission/view-menu pairs with no successor and 12 deprecated permissions that were renamed/consolidated into current permissions the fix handles these through two targeted Alembic migrations: pure deletions and role-preserving renames i deliberately avoided a global "stale permission" sweep or allow-list, since permissions can vary by configuration/features and object-level permissions such as `database_access`, `datasource_access`, `schema_access`, and `catalog_access` must remain untouched the changes also add regression coverage for role associations, orphan cleanup, shared permissions, idempotency, dynamic permissions, and the rename path I'll open a PR with the full details shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
