rusackas commented on code in PR #44130:
URL: https://github.com/apache/superset/pull/44130#discussion_r3982654843
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -736,6 +736,7 @@ Each tool declares one or more required FAB permissions.
The table below maps to
| `list_charts`, `get_chart_info`, `get_chart_data`, `get_chart_preview`,
`generate_chart`, `update_chart` | `can_read` on `Chart` (read), `can_write` on
`Chart` (mutate) |
| `list_dashboards`, `get_dashboard_info`, `generate_dashboard`,
`add_chart_to_existing_dashboard` | `can_read` on `Dashboard` (read),
`can_write` on `Dashboard` (mutate) |
| `list_datasets`, `get_dataset_info`, `create_virtual_dataset`
| `can_read` on `Dataset` (read), `can_write` on
`Dataset` (mutate) |
+| `list_metrics`, `get_table`, `get_compatible_dimensions`,
`get_compatible_metrics` | `can_read` on `Dataset`
|
Review Comment:
Good catch, fixed — the row now notes the metadata permission gate
(`can_get_drill_info`/`can_get_or_create_dataset`/`can_write` on `Dataset`)
plus the per-view access check external semantic views enforce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
