aminghadersohi commented on PR #44152: URL: https://github.com/apache/superset/pull/44152#issuecomment-5627832810
Finite CI/review follow-up pushed in b7024009d5c3a0ed7145f2047d54d184d8e3cd94, after normal merge 6d2a824812279fc48146e38cf21fc04fd3007310 of upstream master (89565db). No history rewrite. - Inspected both attempts of [Python-Unit run 34543844720](https://github.com/apache/superset/actions/runs/34543844720/attempts/2): each passed 15,236 tests; the retry also passed all 1,717 SQL tests at 100% coverage. Both were cancelled by the 30-minute job budget, not failing assertions. - Applied the identical shared 40-minute budget/comment from #43770/#43771. All test commands, scoped 100% coverage thresholds, artifact uploads and required-gate enforcement remain unchanged. - Addressed the nullable-format review finding: null uses SMART_NUMBER fallback. The real Vega/Vega-Lite renderer tests both explicit and null formats, checking geometry, labels and warnings. - Invalid fresh/cached partial previews return a structured validation error; simply skipping hydration would allow an incomplete configuration farther into the pipeline. Saved updates already had an outer exception handler, but now report a targeted validation error before mutation/rollback handling. Registered FastMCP regressions cover malformed saved metrics and missing/unknown cache datasource state. - Deduplicated compile error classification. Cached static discovery schema compilation with defensive copies; a regression proves one compilation and response-mutation isolation. Registry/feature checks still run on every request. - Retained defensive validation in independently callable preview helpers, type-narrowing assertions, and Gauge's existing numeric contract. Rejection tests remain parametrized over every saved/cache/export path to ensure none bypass validation. Deferred MCP imports avoid changing application-registration order. Eight added/strengthened review regression cases fail against b5ea026 and pass after the fixes (the same selection also retains five passing controls). Focused suites: **115 passed**, including actual renderer execution. Full branch-file pre-commit (MyPy, Ruff, Pylint, formatting and workflow audit), compile and diff checks passed. Full MCP/common rerun and exact-head CI are in progress; final evidence will follow. No additional review cycle was requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
