aminghadersohi commented on code in PR #44146:
URL: https://github.com/apache/superset/pull/44146#discussion_r3985522889
##########
superset/mcp_service/dataset/tool/list_datasets.py:
##########
@@ -91,6 +92,14 @@ async def list_datasets(
semantic-layer datasets; false returns only uncertified datasets, while
omitting it preserves the unfiltered behavior.
+ Search matches schema, SQL, table name, and description as case-insensitive
Review Comment:
Addressed in 33d8a0483d. The authoritative docstring list now includes
`uuid` and includes a complete `{"col": "uuid", "opr": "eq", "value": "..."}`
example. The compatibility `search=<uuid>` form is documented as well.
##########
superset/mcp_service/common/schema_discovery.py:
##########
@@ -358,7 +358,12 @@ def get_columns_from_model(
"changed_on_delta_humanized",
"created_on",
]
-DATASET_SEARCH_COLUMNS = ["table_name", "description"]
+# Single source of truth for what ``list_datasets`` searches, so ``get_schema``
+# and the schema resource cannot drift from the tool's actual behavior.
``uuid``
+# is deliberately absent: it is a binary column, and the substring search casts
+# to text, so a hyphenated UUID string can never match. Look datasets up by
UUID
+# with a ``uuid`` filter instead.
+DATASET_SEARCH_COLUMNS = ["table_name", "description", "schema", "sql"]
Review Comment:
Addressed in 33d8a0483d. Full UUID-shaped `search` values are now detected
before generic substring search and converted to an exact typed `uuid = ...`
filter. This preserves the PostgreSQL/CockroachDB behavior while also making it
work on SQLite and other binary-storage backends. Non-UUID search terms still
use the advertised substring columns, and both paths have focused regression
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
