rusackas commented on PR #40078: URL: https://github.com/apache/superset/pull/40078#issuecomment-5630202274
@sha174n on the committed-vs-CI-built question, SIP_DRAFT.md already covers it: the GeoJSON output gets committed so a fresh ephemeral env can render without running the build first, and the regen workflow just diffs CI's rebuild against that to catch drift, it's not building anything at request time. Bigger problem though: `master` already shipped a `plugin-chart-country-map` (dropping the `legacy-` prefix) via #41714, using the old per-country geojson + notebook pipeline. That's the same path this PR wants, with a totally different design, so this isn't a rebase conflict anymore, it's two implementations claiming the same slot. Needs sorting out before a rebase here would even mean anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
