sadpandajoe commented on code in PR #43512:
URL: https://github.com/apache/superset/pull/43512#discussion_r3990074758
##########
superset-frontend/package.json:
##########
@@ -271,7 +271,7 @@
"@testing-library/dom": "^10.4.1",
"@testing-library/jest-dom": "^7.0.1",
"@testing-library/react": "^16.3.3",
- "@testing-library/user-event": "^12.8.3",
+ "@testing-library/user-event": "^14.6.5",
Review Comment:
This v14 bump leaves async interactions unawaited in unchanged tests, so
some assertions run before the event: `CopyToClipboard.test.tsx:111` checks
tooltip absence immediately after `hover`, and
`plugins/plugin-chart-word-cloud/test/ColorSchemeControl.test.tsx:78` checks
`onChange` immediately after `click`. Could the remaining calls be awaited,
keeping `fireEvent` only where synchronous dispatch is intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
