EnxDev commented on code in PR #43458:
URL: https://github.com/apache/superset/pull/43458#discussion_r3990676541
##########
superset-frontend/src/components/ErrorMessage/DatasourceSecurityAccessErrorMessage.tsx:
##########
@@ -109,7 +110,7 @@ export function DatasourceSecurityAccessErrorMessage({
const description: ReactNode = (
<>
<div>{ownerLine}</div>
- {extra?.link && (
+ {extra?.link && extra?.is_access_denial && (
Review Comment:
Thanks, the production condition handles table links correctly now. Could we
still add the regression assertion to the existing TABLE_SECURITY_ACCESS_ERROR
test? Its fixture replaces `extra` with only `tables`, so the corrected
`extra.link` branch is not exercised and a future change to this safety gate
could silently remove table links again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
