rusackas opened a new pull request, #44175: URL: https://github.com/apache/superset/pull/44175
### SUMMARY `underscore` has zero first-party usage anywhere in `src`/`plugins`/`packages` — the only hits for the literal string "underscore" in the codebase are `eslint-disable no-underscore-dangle` directive comments, unrelated to the npm package. `lodash-es` already covers the same ground and is what's actually used throughout (178 files). ### CHANGES - Removed `underscore` from `package.json` `devDependencies`. - Regenerated `package-lock.json` via `npm install`. The only remaining `underscore` entry afterward is a transitive dependency of `nomnom` (a different, older version, nested under its own `node_modules`) — untouched. ### TESTING INSTRUCTIONS `grep -rl "from 'underscore'" --exclude-dir=node_modules src plugins packages` returns nothing before or after this change (it was already unused). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
