mikebridge commented on PR #44012: URL: https://github.com/apache/superset/pull/44012#issuecomment-5639914929
Folded in the `naive_utcnow` dedupe as asked (80d3c6683c): the canonical definition stays in `superset/utils/dates.py` and `superset/tasks/utils.py` now re-exports it, so the task modules importing from there are unchanged — behaviour-preserving (both bodies were identical), and the "one helper" docstring claim is now structurally true. Also rebased onto master and refreshed the description's test counts: 6 in the file, the versioning suite is now 158 (master gained 7 versioning tests since `eff38b0`), and the reverted-fix control still flips 4 of 6 — re-run after the dedupe to confirm it can't mask the fix. Thanks for the thorough verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
