bito-code-review[bot] commented on PR #43974: URL: https://github.com/apache/superset/pull/43974#issuecomment-5639835024
<!-- Bito Reply --> Your analysis of the ODBC connection string precedence is correct. According to the `SQLDriverConnect` specification, the driver typically respects the first occurrence of a keyword, meaning an embedded `Database=` in the `odbc_connect` string would indeed take precedence over a keyword argument passed to `pyodbc.connect()`. Since this logic is used for authorization decisions, adding a safety check to return `None` when both sources are present and disagree is a prudent approach to avoid incorrect normalization. You may want to implement that check as you suggested to ensure the system defaults to a safer state in ambiguous configurations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
