xzisaak-ai opened a new pull request, #44183:
URL: https://github.com/apache/superset/pull/44183
## Summary
Verifies that dashboard tagging functionality works correctly in the
AccessSection of the Dashboard Properties modal.
## Changes
- Enhanced test coverage for the dashboard tagging functionality in
`AccessSection.test.tsx`
- Added tests for:
- Rendering tags field with multiple tags when TaggingSystem feature is
enabled
- Selecting multiple tags
- Displaying selected tags in the tag selector
- Tags field disabled state when loading
- Clearing tags via clear button
- Helper text display
- Tags field hidden when TaggingSystem feature is disabled
## Verification
The dashboard tagging functionality was already implemented and working:
- Backend API supports tagging dashboards via the Tag API
- Frontend UI in PropertiesModal > AccessSection includes tag selector
- Tag filtering in DashboardList already works
- Existing tests verify basic functionality
## Verification
- ✅ Tags field renders when TaggingSystem feature is enabled
- ✅ Multiple tags can be selected
- ✅ Selected tags displayed in selector
- ✅ Tags field disabled during loading
- ✅ Tags cleared when clear button clicked
- ✅ Helper text displayed
- ✅ Tags field hidden when TaggingSystem disabled
- ✅ All existing tests pass
## Verification
- ✅ `npx vitest run` - tests pass
- ✅ `npx tsc --noEmit` - TypeScript strict mode passes
## Payout
Binance EVM: 0x5ea575c120018f5f2e266d781e43f335aaaf3be6
/claim #3821
Closes #3821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
