mikebridge opened a new pull request, #44185: URL: https://github.com/apache/superset/pull/44185
### SUMMARY `charts_attached_to_dashboard` returns `[attach, detach)` attachment **windows** in transaction-id space — one entry per attachment episode, for every chart that has **ever** been on the dashboard — not present membership. The name read as a membership query, and that misreading is the common root of three M2M-shadow bugs (sc-119770, sc-119907, sc-120007). This renames it to `chart_attachment_windows_for_dashboard` across all 17 references (`superset/versioning/` + tests) and rewrites the docstring so the summary line states the history-not-membership contract outright. Mechanical rename; **no behavior change** — no call site's logic is touched. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — internal rename, no UI change. ### TESTING INSTRUCTIONS ```bash pytest tests/unit_tests/versioning/ # 152 passed grep -rn "charts_attached_to_dashboard" superset/ tests/ # empty ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01C7U5oFfrqUyM6hJTZiW2uf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
