bito-code-review[bot] commented on code in PR #44152:
URL: https://github.com/apache/superset/pull/44152#discussion_r3989841104
##########
superset/mcp_service/chart/tool/update_chart_preview.py:
##########
@@ -177,6 +178,39 @@ def update_chart_preview( # noqa: C901
NORMALIZATION_EXCEPTIONS,
)
+ warnings: list[str] = []
+ previous_form_data: dict[str, Any] | None = None
+
+ if request.form_data_key:
+ previous_form_data =
_get_previous_form_data(request.form_data_key)
+ if previous_form_data is None:
+ warnings.append(INVALID_FORM_DATA_KEY_WARNING)
+ previous_datasource = str(
+ (previous_form_data or {}).get("datasource")
+ or (previous_form_data or {}).get("datasource_id")
+ or ""
+ ).split("__", 1)[0]
+ dataset_rebind = previous_datasource != str(dataset.id) and (
+ bool(previous_datasource) or config.chart_type == "treemap_v2"
+ )
+ try:
+ config = resolve_treemap_update_config(
+ config,
+ previous_form_data or {},
+ dataset_rebind=dataset_rebind,
+ )
+ except ValueError as ex:
+ return {
+ "chart": None,
+ "error": {
+ "error_type": "ValidationError",
+ "message": "Invalid Treemap update configuration",
+ "details": str(ex),
+ },
+ "success": False,
+ "schema_version": "2.0",
+ "api_version": "v1",
+ }
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to catch `pydantic.ValidationError` in
`resolve_treemap_update_config` is unnecessary because
`pydantic_core.ValidationError` inherits from `ValueError`, which is already
caught by the existing handler. The current implementation correctly handles
these validation errors, and the reported uncaught exception is not
reproducible with the provided code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
