mikebridge opened a new pull request, #44190:
URL: https://github.com/apache/superset/pull/44190

   **Depends on #44021** — the "Viewing history" section describes the 
server-side edit gate that PR introduces. Draft until it merges.
   
   ### SUMMARY
   
   Extends the two versioning user pages (`version-history.mdx`, 
`recently-archived.mdx`) toward the full user/operator guide requested for the 
versioning & soft-deletion effort (SC-111917, originally flagged by @rusackas 
in review of #39859): screenshots, the permission model, and the 
retention/purge operator surface.
   
   What's added:
   
   - **Screenshots** (captured from a live build): the version-history panel 
with expanded change descriptions, the preview banner with its Restore / Open 
as new / Close actions, and the Recently Archived list.
   - **Scope note**: version history covers charts and dashboards; datasets 
participate in soft deletion and can be recovered from Recently Archived, but 
their edits are not versioned.
   - **Server-side edit gate** (per #44021): the version and activity endpoints 
refuse users without edit rights on the specific entity — the rule is enforced 
at the API, not just hidden in the UI — and embedded guest tokens are refused 
outright.
   - **Version-history retention** (new section): 
`SUPERSET_VERSION_HISTORY_RETENTION_DAYS` (default 30, non-positive keeps 
history indefinitely), the daily prune task, and the guarantee that live 
versions are never pruned.
   - **Soft-delete retention for operators** (new section on Recently 
Archived): the `superset deletion-retention` CLI (`set-window` / `show-window` 
/ `force-purge`), the resolution order (per-deployment CLI value over the 
`SOFT_DELETE_RETENTION_DAYS` config default of 30), zero-disables semantics, 
and `SOFT_DELETE_PURGE_DRY_RUN` for validating a window before it goes live.
   
   All configuration names, defaults, task names, CLI command names, and 
resolution order were verified against the code (`superset/config.py`, 
`superset/cli/deletion_retention.py`, 
`superset/commands/deletion_retention/window.py`).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Docs-only change. The three images added under 
`docs/static/img/version-history/` are the content of the change and render 
inline on the two pages.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   cd docs && npm install && npm run build
   ```
   
   Then review `/docs/using-superset/version-history` and 
`/docs/using-superset/recently-archived` — images render, the cross-page links 
resolve both ways.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: SC-111917
   - [x] Required feature flags: `VERSION_HISTORY`, `SOFT_DELETE` (the 
documented features)
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01C7U5oFfrqUyM6hJTZiW2uf
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to