rusackas commented on PR #44044: URL: https://github.com/apache/superset/pull/44044#issuecomment-5647590585
Thanks for narrowing this down to the single normalization point in `formatValue.ts`, much cleaner than touching every formatter factory. One thing before we can approve though: `TableChart.tsx:1312` still only checks `typeof value === 'number'` for the negative/positive cell-bar class, so a negative bigint gets styled `positive`. Bito flagged this twice and it's the same pattern you already handle a few lines up for `cellWidth`/`cellOffset`/`cellBackground`, so should be a quick fix, @Piyush-08-bot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
