rusackas commented on PR #43960: URL: https://github.com/apache/superset/pull/43960#issuecomment-5647781652
Nice, thanks for chasing this down further. Looks like the Trino space-before-offset case sadpandajoe flagged is handled now (92259144a9), and the tests cover it plus the DST edge case, good work there. Only other open thread is CodeAnt's point about compact offsets like `+0330` going straight into `new Date()` without a colon, that's worth a quick look since it's non-ISO and browsers aren't required to agree on parsing it, if you don't mind making the touchup. Good to merge from my end otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
