bito-code-review[bot] commented on PR #44112: URL: https://github.com/apache/superset/pull/44112#issuecomment-5648994098
<!-- Bito Reply --> The flagged issue is correct. The current implementation defaults `zebraStriping` to `false` in `transformProps.ts`, which causes existing Table V2 charts (which lack this key) to lose their default striped appearance. To resolve this, you should update the default value in `transformProps.ts` to `true` to maintain backward compatibility for existing charts. Would you like me to implement this fix and check the rest of the comments on this PR? **superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts** ``` zebraStriping: !!formData?.zebra_striping ?? true, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
