hainenber opened a new pull request, #44210: URL: https://github.com/apache/superset/pull/44210
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> chore(build): remove `ts-jest` usage for TS7 preparation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Using `ts-jest` means we want to have type-checking for the frontend Jest-based tests. However, this is redundant since (1) there is [a separate type-checking CI step](https://github.com/apache/superset/blob/master/.github/workflows/superset-frontend.yml#L164) that always run for FE file changes and (2) we don't use any Typescript-exclusive features as described in [`ts-jest` docs](https://kulshekhar.github.io/ts-jest/docs/babel7-or-ts). I tried using `@swc/jest` but it's not a drop-in replacement; we'll need to change a lot of `jest.spyOn` references, which is a lot ([issue](https://github.com/swc-project/swc/issues/3843)). Moreover, there is a speedup due to absence of heavy typechecking and this removal prepares ourselves in a good way for TS7, given that TS7 support on `ts-jest` is uncertain atm ([issue](https://github.com/kulshekhar/ts-jest/issues/5366)) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Green Ci ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
