aminghadersohi commented on code in PR #44179: URL: https://github.com/apache/superset/pull/44179#discussion_r4002391485
########## docs/docs/using-superset/recently-archived.mdx: ########## @@ -54,6 +54,11 @@ returns to its normal list and disappears from the archive. Recovering is limited to the object's editors and admins; you can only recover objects you are able to see in this view. +Seeing an archived object and acting on it are separate permissions: objects +you can view but not edit still appear in the list, but their rows carry no +actions. The **Recover** and **Delete permanently** buttons are shown only +for objects you have permission to edit. Review Comment: The gate is `hidden: !canWrite` — a class-level `can_write` from `_info` applied to the whole Actions column, so it's all-or-nothing per object *type*, not per object. Someone with write on Dashboard still sees **Recover** on archived dashboards they can't recover. ```suggestion actions. The **Recover** and **Delete permanently** buttons appear only if you have edit permission for that object type; recovering a specific object can still be refused if you are not one of its editors. ``` ########## docs/docs/using-superset/recently-archived.mdx: ########## @@ -62,7 +67,8 @@ You will be asked to confirm. This cannot be undone. Unlike archiving, it does not move the object anywhere — the object and its version history are erased, and no retention window applies. The same audience that can recover an object can delete it -permanently: its editors and admins. +permanently: its editors and admins. As with recovery, the action appears +only on rows you have permission to edit. Review Comment: Same per-type vs per-object overstatement as above. ```suggestion permanently: its editors and admins. As with recovery, the action appears only if you have edit permission for that object type; a specific object can still be refused. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
