rusackas commented on code in PR #43471: URL: https://github.com/apache/superset/pull/43471#discussion_r4005852082
########## UPDATING.md: ########## @@ -256,6 +256,30 @@ unknown impact as zero. Chart and dashboard purge endpoints are unchanged. The native "Value" filter's bulk "Select all" / "Clear" controls now operate on the entire loaded set of column values regardless of any text typed into the filter's search box. Previously the "Select all (N)" count briefly flickered to the search-scoped count before settling on the full-column count, and clicking "Select all" while searching could select only the currently matching subset. Search-scoped bulk selection was never a supported feature; the count is now stable and always matches what "Select all" selects (the full column). No configuration change is required. +### Superset no longer auto-generates `type:`/`editor:`/`favorited_by:` tags + +With `TAGGING_SYSTEM` enabled, Superset used to auto-tag every chart, +dashboard, saved query, and dataset with implicit tags derived from +metadata (object type, editors, and who favorited it), and generate a +`favorited_by:<user id>` tag on every favorite/unfavorite. Nothing in the +UI ever surfaced these tags to users — every tags list and filter in the +frontend explicitly excluded them — so the generation added continuous +write overhead (13 SQLAlchemy event listeners across 5 models) with no +user-visible benefit. That generation is removed. + +Manually-created (custom) tags are unaffected: creating, editing, +listing, and filtering tags still works exactly as before, including the +`custom_tag` API filter used to distinguish custom from implicit tags. + +Deployments already running with `TAGGING_SYSTEM` enabled keep any +`type:`/`editor:`/`favorited_by:` tag rows created before upgrading — they +remain queryable via the API and MCP's `list_tags`/`get_tag_info` tools, +and are still exempt from bulk tag deletion — but no new ones are created, +and the `superset sync_tags` CLI command that backfilled them has been +removed. The `DASHBOARD_LIST_CUSTOM_TAGS_ONLY` config flag and the Review Comment: Fixed both — the DASHBOARD_LIST_CUSTOM_TAGS_ONLY paragraph now says it was kept (default False) rather than removed, and reworded the older "Implicit tags accrue" bullet to point at the removal instead of contradicting it. ########## UPDATING.md: ########## @@ -256,6 +256,30 @@ unknown impact as zero. Chart and dashboard purge endpoints are unchanged. The native "Value" filter's bulk "Select all" / "Clear" controls now operate on the entire loaded set of column values regardless of any text typed into the filter's search box. Previously the "Select all (N)" count briefly flickered to the search-scoped count before settling on the full-column count, and clicking "Select all" while searching could select only the currently matching subset. Search-scoped bulk selection was never a supported feature; the count is now stable and always matches what "Select all" selects (the full column). No configuration change is required. +### Superset no longer auto-generates `type:`/`editor:`/`favorited_by:` tags + +With `TAGGING_SYSTEM` enabled, Superset used to auto-tag every chart, +dashboard, saved query, and dataset with implicit tags derived from +metadata (object type, editors, and who favorited it), and generate a +`favorited_by:<user id>` tag on every favorite/unfavorite. Nothing in the +UI ever surfaced these tags to users — every tags list and filter in the +frontend explicitly excluded them — so the generation added continuous +write overhead (13 SQLAlchemy event listeners across 5 models) with no +user-visible benefit. That generation is removed. + +Manually-created (custom) tags are unaffected: creating, editing, +listing, and filtering tags still works exactly as before, including the +`custom_tag` API filter used to distinguish custom from implicit tags. + +Deployments already running with `TAGGING_SYSTEM` enabled keep any +`type:`/`editor:`/`favorited_by:` tag rows created before upgrading — they +remain queryable via the API and MCP's `list_tags`/`get_tag_info` tools, +and are still exempt from bulk tag deletion — but no new ones are created, +and the `superset sync_tags` CLI command that backfilled them has been +removed. The `DASHBOARD_LIST_CUSTOM_TAGS_ONLY` config flag and the Review Comment: Fixed both. The DASHBOARD_LIST_CUSTOM_TAGS_ONLY paragraph now says it was kept (default False) rather than removed, and reworded the older "Implicit tags accrue" bullet to point at the removal instead of contradicting it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
