codeant-ai-for-open-source[bot] commented on code in PR #44240: URL: https://github.com/apache/superset/pull/44240#discussion_r4006795949
########## docs/admin_docs/installation/docker-builds.mdx: ########## @@ -31,38 +31,44 @@ for the build, and/or base image. Here are the build presets that are exposed through the `supersetbot docker` utility: - `superset`: The default Docker image, including both frontend and backend. Tags - without a build_preset suffix are `superset` builds (ie: `latest`, `5.0.0`, `4.1.2`, ...). + without a build_preset suffix are `superset` builds (ie: `latest`, `7.0.0`, `master`, ...). It bundles the common metadata/analytics drivers (`psycopg2-binary` for PostgreSQL and `mysqlclient` for MySQL), the MCP server dependencies, and a headless Chromium (via Playwright) for Alerts & Reports and thumbnail generation, so it is usable out of the box. You'll still need to layer any additional drivers required to connect to your specific analytics database(s). - `lean`: A minimal image, including both frontend and backend but **no database - drivers** โ published under `-lean` tags (ie: `latest-lean`, `5.0.0-lean`, `master-lean`). + drivers** โ published under `-lean` tags (ie: `latest-lean`, `7.0.0-lean`, `master-lean`). That applies to analytics databases **AND the metadata database**, so you'll need to layer either `mysqlclient` or `psycopg2-binary` depending on the metadata database you choose, plus the required drivers to connect to your analytics database(s). Use this when you want the smallest possible image and full control over what gets installed. -- `dev`: For development, with a headless browser, dev-related utilities and root access. This +- `dev`: For development, with dev-related utilities and root access. This includes some commonly used database drivers like `mysqlclient`, `psycopg2-binary` and - some other used for development/CI + some other used for development/CI. The published `-dev` images do not include a headless + browser; to add Chromium, build the `dev` target with `--build-arg INCLUDE_CHROMIUM=true`. - `py311`, e.g., Py311: Similar to lean but with a different Python version (in this example, 3.11). - `ci`: For certain CI workloads. - `websocket`: For Superset clusters supporting advanced features. - `dockerize`: Used by Helm in initContainers to wait for database dependencies to be available. +Release tags follow this `superset`/`lean` naming starting with 7.0.0. Releases up to and +including 6.1.0 publish the minimal image under the plain tag (e.g. `6.1.0`) and have no +`-lean` tag. Review Comment: **Suggestion:** These lines contradict `UPDATING.md`, which documents `5.0.0-lean` and says plain `5.0.0` is batteries-included. Users may choose the wrong image for 5.x and 6.x releases. [docstring mismatch] **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=70c445e782ba48439bfbd9cdc5c36b22&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=70c445e782ba48439bfbd9cdc5c36b22&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/installation/docker-builds.mdx **Line:** 55:57 **Comment:** *Docstring Mismatch: These lines contradict `UPDATING.md`, which documents `5.0.0-lean` and says plain `5.0.0` is batteries-included. Users may choose the wrong image for 5.x and 6.x releases. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44240&comment_hash=269e03acda6dabb51df556c9d4ce5181dab8939069c7f9e4b098c3c2e5119b81&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44240&comment_hash=269e03acda6dabb51df556c9d4ce5181dab8939069c7f9e4b098c3c2e5119b81&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
