gpiccione-ship-it commented on issue #44241: URL: https://github.com/apache/superset/issues/44241#issuecomment-5666686053
Thanks — the `BaseEngineSpec.execute` → `cursor.execute` dispatch is the piece we hadn't traced; that settles it. Happy to verify the PR on our side when it's up. We have a case a stub can't easily reproduce: a dataset whose SQL is a `UNION` over ~7.19M rows on MariaDB 10.6.22, with `max_statement_time = 300` on the connection — that's where the probe ran 557 s and completed. With the fix it should be bounded by a single cap. Ping me on the PR and I'll run it. Agreed on keeping `apply_limit_to_sql` out of this one — the blast radius is much wider. Would you prefer that as a GitHub Discussion or a separate issue? I have the numbers from the same dataset: appended `LIMIT 0` on the UNION > 20 s, the wrapped form `SELECT * FROM (…) WHERE 1=0` 0.005 s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
