codeant-ai-for-open-source[bot] commented on code in PR #44243: URL: https://github.com/apache/superset/pull/44243#discussion_r4007178752
########## docs/admin_docs/configuration/alerts-reports.mdx: ########## @@ -50,13 +50,10 @@ Screenshots will be taken but no messages actually sent as long as `ALERT_REPORT #### In your `Dockerfile` -You'll need to extend the Superset image to include a headless browser. Your options include: +As of 7.0.0, Superset takes screenshots only with [Playwright](https://playwright.dev/python/) driving a headless Chromium browser. Selenium, Firefox, geckodriver and the `WEBDRIVER_TYPE` setting are not supported, and no feature flag is needed to use Playwright. -- Use Playwright with Chromium: this is the recommended approach as of version 4.1.x or greater. Playwright always uses Chromium โ the `WEBDRIVER_TYPE` config setting has no effect when Playwright is active. A working example of a Dockerfile that installs these tools is provided under "Building your own production Docker image" on the [Docker Builds](/admin-docs/installation/docker-builds#building-your-own-production-docker-image) page. Enable the `PLAYWRIGHT_REPORTS_AND_THUMBNAILS` feature flag in your config to activate it. -- Use Firefox (Selenium): you'll need to install geckodriver and Firefox. Set `WEBDRIVER_TYPE` to `"firefox"` in your `superset_config.py`. -- Use Chrome (Selenium): you'll need to install Chrome. Set `WEBDRIVER_TYPE` to `"chrome"` in your `superset_config.py`. - -In Superset versions <=4.0x, users installed Firefox or Chrome and that was documented here. +- The default Superset image (for example the `latest` and `<version>` tags) includes Playwright and Chromium. +- The `lean` image and custom images need them installed, for example with `pip install playwright && playwright install-deps && playwright install chromium`. A working example of a Dockerfile that installs these tools is provided under "Building your own production Docker image" on the [Docker Builds](/admin-docs/installation/docker-builds#building-your-own-production-docker-image) page. Review Comment: **Suggestion:** This custom-image command installs Chromium in the invoking user's default cache, which can be inaccessible when the container later runs as the `superset` user. [possible bug] **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6d9df30364a245deb56ff78cb1d8f351&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6d9df30364a245deb56ff78cb1d8f351&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/alerts-reports.mdx **Line:** 55:56 **Comment:** *Possible Bug: This custom-image command installs Chromium in the invoking user's default cache, which can be inaccessible when the container later runs as the `superset` user. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44243&comment_hash=9d8971b739f5224d8f19a672dc087dbb22b1b11ed54f4b921993a135e8bc96de&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44243&comment_hash=9d8971b739f5224d8f19a672dc087dbb22b1b11ed54f4b921993a135e8bc96de&reaction=dislike'>๐</a> ########## docs/developer_docs/testing/backend-testing.md: ########## @@ -71,6 +71,7 @@ The Alerts & Reports feature relies on Celery for task scheduling and execution. - Redis running on `localhost:6379` - [MailHog](https://github.com/mailhog/MailHog) installed (a local SMTP server with a web UI for viewing caught emails) +- Playwright and Chromium installed, for report screenshots: `pip install playwright && playwright install chromium` Review Comment: **Suggestion:** On a clean host, Chromium can fail to launch because this prerequisite omits `playwright install-deps`, which installs the required operating-system libraries. [possible bug] **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ed91efecfe8f4949a6e84e0761d006bf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ed91efecfe8f4949a6e84e0761d006bf&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/developer_docs/testing/backend-testing.md **Line:** 74:74 **Comment:** *Possible Bug: On a clean host, Chromium can fail to launch because this prerequisite omits `playwright install-deps`, which installs the required operating-system libraries. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44243&comment_hash=1fea4d85817c5b7105a20ddf3110308264442f6a4847f9605f807f2bad6db581&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44243&comment_hash=1fea4d85817c5b7105a20ddf3110308264442f6a4847f9605f807f2bad6db581&reaction=dislike'>๐</a> ########## docs/admin_docs/configuration/dashboard-performance.mdx: ########## @@ -174,7 +174,7 @@ scheduled table in the warehouse so each chart query is a cheap lookup. - See [Feature Flags](./feature-flags.mdx) for the full list of supported flags and their lifecycle stages. - Server-side screenshot jobs (alerts, scheduled reports, thumbnails) - render the dashboard in a headless, webdriver-controlled browser, which + render the dashboard in a headless Chromium browser driven by Playwright, which intentionally bypasses row virtualization so the rendered artifact includes every chart, not just the ones above the fold. User-triggered Review Comment: **Suggestion:** This promises every chart, but inactive dashboard tabs remain hidden, so their charts are not rendered or included in the screenshot. [logic error] **Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` [](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5efaecb9bda440f196306107cf1c526a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5efaecb9bda440f196306107cf1c526a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** docs/admin_docs/configuration/dashboard-performance.mdx **Line:** 177:179 **Comment:** *Logic Error: This promises every chart, but inactive dashboard tabs remain hidden, so their charts are not rendered or included in the screenshot. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44243&comment_hash=dbea99cf148771730d1727554641ada7d6e629e824f904035eb1519662e13ea3&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44243&comment_hash=dbea99cf148771730d1727554641ada7d6e629e824f904035eb1519662e13ea3&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
