sfirke opened a new pull request, #44245: URL: https://github.com/apache/superset/pull/44245
### SUMMARY Master-only cleanup after #43028 removed Selenium support. **Stacked on #44243**, which rewords the `INCLUDE_FIREFOX` docs line this PR deletes. Until #44243 merges, its changes also show in this diff; this PR's own change is commit 215eb98fab. I'll update the branch once #44243 merges. - **`INCLUDE_FIREFOX` build arg:** screenshots only ever launch Chromium (`superset/utils/webdriver.py` calls `chromium.launch`), so the Playwright Firefox this arg installed is never used. Removed from the `Dockerfile`, `docker-compose.yml`, `docker-compose-light.yml`, `docs/admin_docs/installation/docker-builds.mdx` and `docs/developer_docs/contributing/development-setup.md`. `INCLUDE_CHROMIUM` is unchanged. The `docker-builds.mdx` change is a one-line hunk that doesn't overlap #44240. - **`EMAIL_PAGE_RENDER_WAIT`:** nothing has read this config key since #19261, and its comment still described Selenium. - **`ENABLE_PLAYWRIGHT=false` in `docker/.env`:** added in #27953, the same PR that removed the bootstrap step that installed Playwright; nothing reads it. - **`UPDATING.md`:** notes the removals. Because this removes a build arg and a config key, it's intended for master only. The text-only fixes suitable for 7.0 are in #44244. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS - `docker build --check .` reports no issues. - `docker compose -f docker-compose.yml config -q` and `docker compose -f docker-compose-light.yml config -q` succeed. - Build with `--build-arg INCLUDE_CHROMIUM=true` and confirm Chromium is present under `/usr/local/share/playwright-browsers`. - `git grep -n -E 'INCLUDE_FIREFOX|EMAIL_PAGE_RENDER_WAIT|ENABLE_PLAYWRIGHT' -- ':!docs/*_versioned_docs' ':!CHANGELOG' ':!UPDATING.md'` returns nothing. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [x] Removes existing feature or API --- 🤖 _Drafted by Claude Code, co-signed by @sfirke._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
