fitzee commented on PR #44191: URL: https://github.com/apache/superset/pull/44191#issuecomment-5671448568
Addressed the sparse-dashboard false positive in 921b2cde7f. Combined-image validation now rechecks the corresponding content-bearing tile regions rather than classifying the full composite, so permitted empty-state tiles cannot dilute valid sparse content. A real-combiner regression test covers one sparse content tile plus seven empty tiles, while the existing corruption test still proves that lost content fails closed. I also replaced invalid `b"combined"` mocks with real PNGs, used `capture_was_rejected` in the gate, and corrected the thumbnail log documentation. Validation: 328 passed, 1 skipped; pinned Ruff/MyPy passed; Superset Pylint plugin 10/10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
