deepujain opened a new pull request, #44273:
URL: https://github.com/apache/superset/pull/44273

   ### SUMMARY
   
   Generate Russia's country map from Natural Earth's correct 1:10m 
administrative boundaries instead of its known-bad 1:50m geometry. The 
regenerated map now gives Karelia its full `RU-KR` boundary and stops Murmansk 
from absorbing Karelia.
   
   The generator keeps only named administrative regions and adds a tiny 
dateline separation when shifting Chukchi so GeoJSON serialization preserves 
valid geometry. A focused regression test pins the 85 named regions, unique ISO 
codes, and distinct geographic extents of Karelia and Murmansk.
   
   Fixes #30326
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   The issue screenshots show the before and expected result. The generated 
geometry changes are also captured by the new bounds regression test.
   
   ### TESTING INSTRUCTIONS
   
   From `superset-frontend`:
   
   ```bash
   npm run test -- plugins/plugin-chart-country-map/test
   PATH="$PWD/node_modules/.bin:$PATH" node scripts/build.js 
--globs=country-map --globs=country-map
   ```
   
   The Jest run should report 7 passing suites and 26 passing tests. The 
country-map package should complete its Babel, ESM, and TypeScript builds.
   
   The generated GeoJSON was additionally checked for 85 features, unique ISO 
codes, non-empty names, and valid geometries.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: #30326
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to