bito-code-review[bot] commented on PR #44218:
URL: https://github.com/apache/superset/pull/44218#issuecomment-5676721290
<!-- Bito Reply -->
The suggestion to use a nonzero `row_offset` in the test case is
appropriate. Using a nonzero value, such as `20`, would effectively verify that
the implementation correctly passes the offset through to the query context,
rather than defaulting to `0` or ignoring the input. This improves the test's
robustness by ensuring that pagination parameters are handled accurately.
**tests/unit_tests/tasks/test_export_dashboard_excel.py**
```
# ... existing setup ...
payload =
mocks["ChartDataQueryContextSchema"].return_value.load.call_args.args[0]
# ...
query = payload["queries"][0]
assert query["row_limit"] == 1000
assert query.get("row_offset", 0) == 20
assert not query.get("is_rowcount")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
