geido commented on PR #44144: URL: https://github.com/apache/superset/pull/44144#issuecomment-5677182023
Bito follow-up after a55d5eb89c (the review reported 0 actionable and 5 additional suggestions): - The Playwright readiness invocation is valid: evaluate invokes a passed function declaration. Both standard and tiled strict captures completed in the rebuilt Docker E2E matrix, so this was not changed. - The lock wait is deliberately bounded to one second so a racing request can observe the winner's newly published generation rather than manufacture another response contract; the eight-way E2E test produced one accepted request and seven observers of one key. - The cache-read compatibility concern was valid and is fixed: get_from_cache_key preserves the legacy miss-on-error default, while only the dashboard screenshot API opts into ScreenshotCacheError so it can return 503 without enqueueing duplicate work. Unit and integration regressions cover both behaviors. - Raw writes remain unchanged for ordinary chart/thumbnail capture to avoid expanding this bug fix into their legacy cache-failure behavior; strict API/UI capture alone requires confirmed persistence. - Extending the new post-capture transition check to scheduled reports is outside this narrowed API/UI fix. The rebase retains master's report-specific fail-closed behavior, including its per-contentful-region combined-image validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
