Kunal8954 commented on code in PR #44169:
URL: https://github.com/apache/superset/pull/44169#discussion_r4016953019
##########
superset/models/dashboard.py:
##########
@@ -358,7 +358,7 @@ def datasets_trimmed_for_slices(
# Use the eagerly-loaded datasource from any slice in the group
datasource = next(iter(slices)).datasource
- if datasource:
+ if isinstance(datasource, BaseDatasource):
Review Comment:
Good catch. I’ll change the grouping to include the datasource type and add
coverage for table/semantic-view ID collisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
